Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide notebook support for Qute #546

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Provide notebook support for Qute #546

wants to merge 1 commit into from

Conversation

JessicaJHee
Copy link
Contributor

Fixes #420

Signed-off-by: Jessica He [email protected]

@rgrunber
Copy link
Member

rgrunber commented Sep 16, 2022 •
edited
Loading

Try something like a cell that has just {foo} or some property that doesn't exist. VS Code will also throw an error indicating the request failed.

[Trace - 9:53:58 a.m.] Sending request 'workspace/executeCommand - (1)'.
Params: {
    "command": "qute.generate",
    "arguments": [
        "{foo}",
        "{\n\t\"friends\": [\"Max\", \"Fred\"]\n}"
    ]
}


[Trace - 9:53:58 a.m.] Received response 'workspace/executeCommand - (1)' in 26ms. Request failed: Property "foo" not found on the base object "com.google.gson.internal.LinkedTreeMap" in expression {foo} in template 1 on line 1 (-32001).
Error data: {
    "message": "Property \"foo\" not found on the base object \"com.google.gson.internal.LinkedTreeMap\" in expression {foo} in template 1 on line 1"
}


[Error - 9:53:58 a.m.] Request workspace/executeCommand failed.
  Message: Property "foo" not found on the base object "com.google.gson.internal.LinkedTreeMap" in expression {foo} in template 1 on line 1
  Code: -32001 
[object Object]

@angelozerr
Copy link
Contributor

Try something like a cell that has just {foo} or some property that doesn't exist. VS Code will also throw an error indicating the request failed.

Indeed there ar esome limitations, but do you think we could merge this notebook support? @fbricon what do you think abiut this PR?

@fbricon
Copy link
Collaborator

fbricon commented Jan 4, 2023

@angelozerr I'm not convinced anyone needs this feature. Unless @maxandersen really wants it, I'd keep it on the shelf.
If we do include it, then I want to see some telemetry, to track its usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notebook support for Qute
4 participants
@JessicaJHee @rgrunber @angelozerr @fbricon